046 Tersters ONLY

A place to report bugs and discuss testing
Message
Author
Datahead
Posts: 710
Joined: Fri Jan 27, 2012 6:50 am
Location: San Marcos, Ca.

Re: 046 Tersters ONLY

#41 Post by Datahead » Mon Aug 03, 2015 3:33 pm

OSA 4.6 - R3 Progress report.
While the overall function of the system seems to be working good there are several quirks I have noticed. I will look closer at the logs and post.

1. While the W800RF is working correctly it seems the learning mode will not shut off... Given my antenna array I now know every RF sensor on my block... LOL

2. The Insteon plugin is working great with the exception of in the logs it says:

nsteon: Plugin Version = 0.4.6
08-03 16:31:36.03 INFO OSAE.Insteon.Insteon Insteon PLM connected at 39.02.C2
08-03 16:31:36.03 INFO OSAE.Plugin Insteon: Plugin Enabled = True
08-03 16:31:35.06 ERROR OSAE.Insteon.Insteon Error in Own Types: Object reference not set to an instance of an object.
08-03 16:31:35.06 INFO OSAE.Insteon.Insteon INSTEON DIMMER Object Type is correctly owned by: Insteon
08-03 16:31:35.06 INFO OSAE.Insteon.Insteon INSTEON Object Type is correctly owned by: Insteon
08-03 16:31:35.06 INFO OSAE.Insteon.Insteon Plugin Debug Mode is set to: False
08-03 16:31:35.05 INFO OSAE.Insteon.Insteon COM Port is set to: 3
08-03 16:31:34.05 INFO OSAE.Plugin Insteon: Activating Plugin...
08-03 16:31:34.04 INFO OSAE.Plugin Insteon: Enabling Plugin...
08-03 16:31:34.04 INFO OSAE.Plugin Insteon: Plugin Object found. Plugin Object Enabled = 1
08-03 16:31:34.03 INFO OSAE.Plugin Insteon: Connection Passed (True)

volfan6415
Posts: 175
Joined: Sun Jun 08, 2014 9:24 am

Re: 046 Tersters ONLY

#42 Post by volfan6415 » Tue Aug 04, 2015 1:13 pm

With respect to the insteon log errors:

It looks like your are missing the insteon relay object type. Try manually adding the object type back in:

Name: Insteon Relay
Desc: Insteon Relay
Owned By: Insteon
Base Type: Binary Switch
Check box for Reserved System Type

Add states, methods and events of On and Off
Property: Off Timer, type: integer

The .4.6 database should be adding this object type so curious to see if it is not correctly adding the type on the install?

Datahead
Posts: 710
Joined: Fri Jan 27, 2012 6:50 am
Location: San Marcos, Ca.

Re: 046 Tersters ONLY

#43 Post by Datahead » Tue Aug 04, 2015 6:33 pm

Thanks Zach,
I haven't restarted the system yet as I am on a remote computer other than the OSA Server but I did add the object type. Will let you know if it worked.

Datahead
Posts: 710
Joined: Fri Jan 27, 2012 6:50 am
Location: San Marcos, Ca.

Re: 046 Tersters ONLY

#44 Post by Datahead » Tue Aug 04, 2015 8:16 pm

Looks like that did the trick for the Insteon plugin, now all we need to do is figure out why the learning mode is not shutting off and we'll be set. Cool beans!

volfan6415
Posts: 175
Joined: Sun Jun 08, 2014 9:24 am

Re: 046 Tersters ONLY

#45 Post by volfan6415 » Tue Aug 04, 2015 8:57 pm

Glad that fixed the insteon plugin, I'm curious why the object isn't being added with the .4.6 install and in any event the plugin should really be adding the object type back in anyways I will look into that

Vaughn
Site Admin
Posts: 1432
Joined: Thu May 13, 2010 2:17 pm

Re: 046 Tersters ONLY

#46 Post by Vaughn » Wed Aug 05, 2015 12:31 pm

The SQL for both plugins is out of date. Good news is neither of these errors affect the 046 core, I just have to update the plugins.

The W800RF is missing the Method to turn debug On/Off. Setting the Property seems to work fine, just remember, properties are not monitored, so if you change a plugin's property, you have to restart the service so it will read that property on startup. Methods are the only thing that can change a running plugin.

I will get both re-published shortly.

Vaughn

Vaughn
Site Admin
Posts: 1432
Joined: Thu May 13, 2010 2:17 pm

Re: 046 Tersters ONLY

#47 Post by Vaughn » Wed Aug 05, 2015 12:53 pm

Argh, I did find a code error, although it is not too serious. I broke the Object_Type export (same issue that broke the install.sql for the plugins)

I added a new field to object_type's properties and I did not update the Export or install SQL. I am testing the exports now, then will use them to update the plugins.

Vaughn

Vaughn
Site Admin
Posts: 1432
Joined: Thu May 13, 2010 2:17 pm

Re: 046 Tersters ONLY

#48 Post by Vaughn » Wed Aug 05, 2015 1:57 pm

Just a funny recap of my questionable lazy decisions. So this thread was testing the installer, when the installer was deemed ok enough, I released. This skipped ALL forms of product testing on my end. So a couple quirks in plugins lead me to find more and more issues related to the adding of a new field to both Objects and Object_Type_Property that I have already found multiple issues with. On top of a misspelling when I left a 'j' out of the word object, the object_type_add is misordered IMO. The object_type that the property goes with is the second to last parameter, and it really should be the very first. Although this does not break anything, it makes the exports harder to read and figure out the parameter meanings. I see this all over OSA, especially in the views and it makes troubleshooting all the harder.

Soooo, I am going to fix these routines, reorder, rename the parameters, and put it through a test run.

We tested a full install with this release, but we critically need to test my ability to publish upgrades again. So once I am done with this, I will start on packing it up and see if I can get you guys to test the upgrade process and use it to fix these plugin issues at the same time.

Vaughn
Site Admin
Posts: 1432
Joined: Thu May 13, 2010 2:17 pm

Re: 046 Tersters ONLY

#49 Post by Vaughn » Wed Aug 05, 2015 4:14 pm

For the W800RF Learning mode issue, you can try to run this SQL or build the method by hand with this information:

CALL osae_sp_object_type_method_add('SET LEARNING MODE','Set Learning Mode','W800RF','True/False','','TRUE','');
_________________________________^Name_____________^Label__________________^Param Label_^Param Default

That should allow you to turn it on and off realtime without restarting the service.



As relating to the previous post:

see how the W800RF is the middle parameter above? in version 047 it looks like this:
CALL osae_sp_object_type_method_add('W800RF','SET LEARNING MODE','Set Learning Mode','True/False','','TRUE','');

Minor difference, but 1 little change like that caused the DB procs, API, web pages add & export to all have to be updated, and may have broke other plugins than would use that call, which is why it probably never got changed =)... Anyways, I got it done and tested.

Datahead
Posts: 710
Joined: Fri Jan 27, 2012 6:50 am
Location: San Marcos, Ca.

Re: 046 Tersters ONLY

#50 Post by Datahead » Thu Aug 06, 2015 5:22 pm

Sorry I haven't been very active the last few days, I have my 58th birthday party coming up and were trying to get the house ready.. After Saturday I should be a little more active as to testing.

Ron

Post Reply